[PATCH v2] cxl: no need to check return value of debugfs_create functions

Michael Ellerman patch-notifications at ellerman.id.au
Sun Jun 30 18:37:26 AEST 2019


On Wed, 2019-06-12 at 15:54:18 UTC, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Because there's no need to check, also make the return value of the
> local debugfs_create_io_x64() call void, as no one ever did anything
> with the return value (as they did not need to.)
> 
> And make the cxl_debugfs_* calls return void as no one was even checking
> their return value at all.
> 
> Cc: Frederic Barrat <fbarrat at linux.ibm.com>
> Cc: Andrew Donnellan <ajd at linux.ibm.com>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: linuxppc-dev at lists.ozlabs.org
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
> Reviewed-by: Frederic Barrat <fbarrat at linux.ibm.com>
> Acked-by: Andrew Donnellan <ajd at linux.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1b7de1df997a57e3e144bdb31ceaee9c16d6d284

cheers


More information about the Linuxppc-dev mailing list