[PATCH 06/28] powerpc/64s/exception: remove the "extra" macro parameter

Michael Ellerman mpe at ellerman.id.au
Wed Jun 19 20:02:04 AEST 2019


Nicholas Piggin <npiggin at gmail.com> writes:
> Nicholas Piggin's on June 12, 2019 12:30 am:
>> @@ -265,7 +275,7 @@ ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE)
>>  EXC_REAL_END(machine_check, 0x200, 0x100)
>>  EXC_VIRT_NONE(0x4200, 0x100)
>>  TRAMP_REAL_BEGIN(machine_check_common_early)
>> -	EXCEPTION_PROLOG_1(PACA_EXMC, NOTEST, 0x200)
>> +	EXCEPTION_PROLOG_1 EXC_HV, PACA_EXMC, 0, 0x200
>>  	/*
>>  	 * Register contents:
>>  	 * R13		= PACA
>
> This is a little bug here, machine check is an EXC_STD exception. It
> does not show up as generated code problem because EXCEPTION_PROLOG_1
> does not actually do anything with this parameter if KVM is false,
> which it is here.
>
> Still, it's wrong. I may just resend the series, because it caused a
> few conflicts in subsequent patches, and I have a few more to add to
> the end.

OK. I'll pull the series out for now.

cheers


More information about the Linuxppc-dev mailing list