[PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

Stephen Rothwell sfr at canb.auug.org.au
Tue Jul 30 14:45:26 AEST 2019


Hi all,

On Tue, 30 Jul 2019 14:37:04 +1000 Stephen Rothwell <sfr at canb.auug.org.au> wrote:
>
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: powerpc):
> 
> drivers/macintosh/smu.c: In function 'smu_queue_i2c':
> drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    cmd->info.devaddr &= 0xfe;
>    ~~~~~~~~~~~~~~~~~~^~~~~~~
> drivers/macintosh/smu.c:855:2: note: here
>   case SMU_I2C_TRANSFER_STDSUB:
>   ^~~~
> 
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Cc: Gustavo A. R. Silva <gustavo at embeddedor.com>
> Cc: Kees Cook <keescook at chromium.org>
> Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>

Fixes: 0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")

Sorry, forgot :-)
-- 
Cheers,
Stephen Rothwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20190730/71e2e8dc/attachment.sig>


More information about the Linuxppc-dev mailing list