[PATCH] powerpc/kvm: Fall through switch case explicitly
Stephen Rothwell
sfr at canb.auug.org.au
Tue Jul 30 13:18:49 AEST 2019
Hi all,
On Mon, 29 Jul 2019 18:45:40 -0500 "Gustavo A. R. Silva" <gustavo at embeddedor.com> wrote:
>
> On 7/29/19 3:16 AM, Stephen Rothwell wrote:
> >
> > On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <santosh at fossix.org> wrote:
> >>
> >> Implicit fallthrough warning was enabled globally which broke
> >> the build. Make it explicit with a `fall through` comment.
> >>
> >> Signed-off-by: Santosh Sivaraj <santosh at fossix.org>
>
> Reviewed-by: Gustavo A. R. Silva <gustavo at embeddedor.com>
>
> Thanks!
> --
> Gustavo
>
> >> ---
> >> arch/powerpc/kvm/book3s_32_mmu.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> >> index 653936177857..18f244aad7aa 100644
> >> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> >> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> >> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
> >> case 2:
> >> case 6:
> >> pte->may_write = true;
> >> + /* fall through */
> >> case 3:
> >> case 5:
> >> case 7:
> >> --
> >> 2.20.1
> >>
> >
> > Thanks
> >
> > Reviewed-by: Stephen Rothwell <sfr at canb.auug.org.au>
> >
> > This only shows up as a warning in a powerpc allyesconfig build.
> >
I will apply this to linux-next today (and keep it until it turns up in
some other tree).
--
Cheers,
Stephen Rothwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20190730/f8481c3c/attachment.sig>
More information about the Linuxppc-dev
mailing list