[PATCH kernel v4 4/4] powerpc/powernv/ioda2: Create bigger default window with 64k IOMMU pages

Christoph Hellwig hch at infradead.org
Sat Jul 13 01:25:49 AEST 2019


> -extern struct iommu_table *iommu_init_table(struct iommu_table * tbl,
> -					    int nid);
> +extern struct iommu_table *iommu_init_table_res(struct iommu_table *tbl,
> +		int nid, unsigned long res_start, unsigned long res_end);
> +#define iommu_init_table(tbl, nid) iommu_init_table_res((tbl), (nid), 0, 0)

I'd just pass the two additional paramters to iommu_init_table, there
are only 10 callers of it.

> +	 * the max order of allocation possible. The TCE tableis likely to

Missing whitespace between tabke and is.

> +	 * end up being multilevel and with on-demand allocation in place,
> +	 * the initial use is not going to be huge as the default window aims
> +	 * to support cripplied devices (i.e. not fully 64bit DMAble) only.

s/cripplied/crippled/


More information about the Linuxppc-dev mailing list