[PATCH 0/2] fix use-after-free in mpc831x_usb_cfg() and do some cleanups

Markus Elfring Markus.Elfring at web.de
Wed Jul 10 02:14:16 AEST 2019

> According to Markus's suggestion, split it into two small patches:

> https://lkml.org/lkml/2019/7/8/520

Thanks that you picked adjustment possibilities up from my feedback.

Now I wonder why you omitted message recipients from the cover letter.
Please keep the address lists usually complete also here for improvements
on the same source file in subsequent patch series.

Can a subject like “[PATCH 0/2] Fix mpc831x_usb_cfg()” be more succinct?

>  powerpc/83xx: fix use-after-free in mpc831x_usb_cfg()

This update variant is generally fine.
I would prefer to avoid the addition of function calls at two places
when the corresponding exception handling should be specified only once
at the end of such a function implementation.

>  powerpc/83xx: cleanup error paths in mpc831x_usb_cfg()

I would find it clearer to fix the error handling in the first update
step completely.
I guess that a renaming of the label “out” into “out_unmap” (or “unmap_io”?)
would be an auxiliary change for the second update step.

I am curious if different preferences for change combinations will trigger
further collateral evolution.


More information about the Linuxppc-dev mailing list