[PATCH v2 03/35] powerpc: Use kmemdup rather than duplicating its implementation

Nathan Lynch nathanl at linux.ibm.com
Wed Jul 10 01:13:05 AEST 2019

Fuqian Huang <huangfq.daxian at gmail.com> writes:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
> Signed-off-by: Fuqian Huang <huangfq.daxian at gmail.com>
> ---
> Changes in v2:
>   - Fix a typo in commit message (memset -> memcpy)

Thanks, but this and the unchecked kmalloc result (and incorrect gfp
flags) have already been addressed in commit
348ea30f51fc63ce3c7fd7dba6043e8e3ee0ef34 ("powerpc/pseries: avoid
blocking in irq when queuing hotplug events"):


More information about the Linuxppc-dev mailing list