[v3 5/7] powerpc/memcpy_mcsafe: return remaining bytes

Nicholas Piggin npiggin at gmail.com
Sat Jul 6 20:05:13 AEST 2019


Christophe Leroy's on July 6, 2019 4:16 pm:
> 
> 
> Le 05/07/2019 à 23:26, Santosh Sivaraj a écrit :
>> memcpy_mcsafe currently return -EFAULT on a machine check exception, change
>> it to return the remaining bytes that needs to be copied, so that machine
>> check safe copy_to_user can maintain the same behavior as copy_to_user.
> 
> AFAIU, this behaviour is the expected behaviour for memcpy_mcsafe(). Why 
> implement a different behaviour in patch 3 and then change it here. 
> Can't memcpy_mcsafe() return remaining bytes as expected from patch 3 ?

+1

This approach might be useful if you copy an existing implementaation
exactly and then make some changes incrementally, but patch 3 is
already modified.

Thanks,
Nick


More information about the Linuxppc-dev mailing list