[PATCH v5 1/2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

Michael Ellerman patch-notifications at ellerman.id.au
Fri Jul 5 01:52:44 AEST 2019

On Tue, 2019-06-04 at 03:00:36 UTC, Michael Neuling wrote:
> From: Mathieu Malaterre <malat at debian.org>
> In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9
> option") the following piece of code was added:
>    smp_call_function((smp_call_func_t)set_dawr, &null_brk, 0);
> Since GCC 8 this triggers the following warning about incompatible
> function types:
>   arch/powerpc/kernel/hw_breakpoint.c:408:21: error: cast between incompatible function types from 'int (*)(struct arch_hw_breakpoint *)' to 'void (*)(void *)' [-Werror=cast-function-type]
> Since the warning is there for a reason, and should not be hidden behind
> a cast, provide an intermediate callback function to avoid the warning.
> Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option")
> Suggested-by: Christoph Hellwig <hch at infradead.org>
> Signed-off-by: Mathieu Malaterre <malat at debian.org>
> Signed-off-by: Michael Neuling <mikey at neuling.org>

Series applied to powerpc next, thanks.



More information about the Linuxppc-dev mailing list