[RESEND PATCH v3] cxl: Wrap iterations over afu slices inside 'afu_list_lock'

Michael Ellerman mpe at ellerman.id.au
Wed Jan 30 23:41:47 AEDT 2019


Vaibhav Jain <vaibhav at linux.ibm.com> writes:

> Within cxl module, iteration over array 'adapter->afu' may be racy
> at few points as it might be simultaneously read during an EEH and its
> contents being set to NULL while driver is being unloaded or unbound
> from the adapter. This might result in a NULL pointer to 'struct afu'
> being de-referenced during an EEH thereby causing a kernel oops.
>
> This patch fixes this by making sure that all access to the array
> 'adapter->afu' is wrapped within the context of spin-lock
> 'adapter->afu_list_lock'.
>
> Cc: stable at vger.kernel.org
> Fixes: 9e8df8a2196("cxl: EEH support")
> Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Acked-by: Frederic Barrat <fbarrat at linux.ibm.com>
> Acked-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
> Changelog:
>
> Resend:
> * Fixed the reference to 'adapter->afu' in patch description. [Andrew]
> * Added the 'Fixes' tag and marked the patch to stable

FYI RESEND means you didn't change anything, but you sent the patch
again for some other reason, like the Cc list was wrong or you thought
it had been ignored.

In this case you should have just sent a v4, updating the change log is
a perfectly valid reason for a new version of the patch.

I've applied it, no need to RESEND ;)

cheers


More information about the Linuxppc-dev mailing list