[PATCH] ucc_geth: Reset BQL queue when stopping device

David Miller davem at davemloft.net
Wed Jan 30 10:33:50 AEDT 2019


From: Mathias Thore <Mathias.Thore at infinera.com>
Date: Tue, 29 Jan 2019 08:07:54 +0000

> Is there a scenario where we are clearing the TX ring but don't want to reset the BQL TX queue?
> 
> I think it makes sense to keep it in ucc_geth_free_tx since the
> reason it is needed isn't the timeout per se, but rather the
> clearing of the TX ring. This way, it will be performed no matter
> why the driver ends up calling this function.

I absolutely think the BQL reset should remain in ucc_geth_free_tx().

That way if another callsite for ucc_geth_free_tx() emerges that does
need the BQL queue reset, it won't be "forgotten".


More information about the Linuxppc-dev mailing list