[1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings
Michael Ellerman
mpe at ellerman.id.au
Sat Jan 12 00:10:11 AEDT 2019
Christian Lamparter <chunkeey at gmail.com> writes:
> On Tuesday, January 8, 2019 10:54:28 AM CET Michael Ellerman wrote:
>> Christian Lamparter <chunkeey at gmail.com> writes:
...
>> diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c
>> index a1aaa1569d7c..f0e488d97567 100644
>> --- a/arch/powerpc/platforms/4xx/ocm.c
>> +++ b/arch/powerpc/platforms/4xx/ocm.c
>> @@ -237,12 +237,12 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
>> continue;
>>
>> seq_printf(m, "PPC4XX OCM : %d\n", ocm->index);
>> - seq_printf(m, "PhysAddr : %pa[p]\n", &(ocm->phys));
>> + seq_printf(m, "PhysAddr : %pa\n", &(ocm->phys));
>> seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal);
>> seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal);
>> seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal);
>>
>> - seq_printf(m, "NC.PhysAddr : %pa[p]\n", &(ocm->nc.phys));
>> + seq_printf(m, "NC.PhysAddr : %pa\n", &(ocm->nc.phys));
>> seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt);
>> seq_printf(m, "NC.MemTotal : %d Bytes\n", ocm->nc.memtotal);
>> seq_printf(m, "NC.MemFree : %d Bytes\n", ocm->nc.memfree);
>> @@ -252,7 +252,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
>> blk->size, blk->owner);
>> }
>>
>> - seq_printf(m, "\nC.PhysAddr : %pa[p]\n", &(ocm->c.phys));
>> + seq_printf(m, "\nC.PhysAddr : %pa\n", &(ocm->c.phys));
>> seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt);
>> seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal);
>> seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree);
>
> Ok, with the patch applied it now looks like:
>
> |root at mbl:/sys/kernel/debug/ppc4xx_ocm# cat info
> |PPC4XX OCM : 1
> |PhysAddr : 0x0000000400040000
> |MemTotal : 32768 Bytes
> |MemTotal(NC) : 32768 Bytes
> |MemTotal(C) : 0 Bytes
> |
> |NC.PhysAddr : 0x0000000400040000
> |NC.VirtAddr : 0x54f5bce2
> |NC.MemTotal : 32768 Bytes
> |NC.MemFree : 32768 Bytes
> |
> |C.PhysAddr : 0x0000000000000000
> |C.VirtAddr : 0x (null)
> |C.MemTotal : 0 Bytes
> |C.MemFree : 0 Bytes
>
> ... just as expected. ;)
Thanks.
cheers
More information about the Linuxppc-dev
mailing list