[PATCH v2 1/3] powerpc: Stop using pr_cont() in __die()

[Michael Ellerman]

Christophe Leroy <christophe.leroy at c-s.fr> writes:
> Le 10/01/2019 à 12:57, Michael Ellerman a écrit :
>> Using pr_cont() risks having our output interleaved with other output
>> from other CPUs. Instead print everything in a single printk() call.
>> 
>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>
> Reviewed-by: Christophe Leroy <christophe.leroy at c-s.fr>
>
>> ---
>>   arch/powerpc/kernel/traps.c | 26 ++++++++------------------
>>   1 file changed, 8 insertions(+), 18 deletions(-)
>> 
>> v2: Use a single printk with (mostly) compile time checks rather than
>> constructing the string with seq_buf.
>> 
>> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
>> index 64936b60d521..164fc92895be 100644
>> --- a/arch/powerpc/kernel/traps.c
>> +++ b/arch/powerpc/kernel/traps.c
>> @@ -257,24 +257,14 @@ static int __die(const char *str, struct pt_regs *regs, long err)
>>   {
>>   	printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter);
>
> Maybe this printk() should also be merge with the following to further 
> limit risks of interleaving ?

Possibly yeah.

Though I was comparing it to other arches and I think we could improve
the info on that line. So I'll leave it for now.

cheers