[PATCH v3 2/2] arch: powerpc/hlwd-pic: Add missing of_node-put() in hlwd_pic_probe()

Himadri Pandya himadri18.07 at gmail.com
Wed Feb 27 20:51:38 AEDT 2019


Decrement the reference count on device_node "np" while breaking out of
the loop. Issue identified by Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07 at gmail.com>
---
Changes in V2:
	- Change subject line
---
Changes in V3:
	- Do not remove the blank line at end of the file
---
 arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 8112b39879d6..df098989e373 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -220,6 +220,7 @@ void hlwd_pic_probe(void)
 			irq_set_chained_handler(cascade_virq,
 						hlwd_pic_irq_cascade);
 			hlwd_irq_host = host;
+			of_node_put(np);
 			break;
 		}
 	}
@@ -232,7 +233,7 @@ void hlwd_pic_probe(void)
  *
  */
 void hlwd_quiesce(void)
-{
+{i
 	void __iomem *io_base = hlwd_irq_host->host_data;
 
 	__hlwd_quiesce(io_base);
-- 
2.17.1



More information about the Linuxppc-dev mailing list