[PATCH v2 2/2] arch: powerpc/hlwd-pic: Add missing of_node-put() in hlwd_pic_probe()

Tyrel Datwyler tyreld at linux.vnet.ibm.com
Tue Feb 26 10:21:52 AEDT 2019


On 02/25/2019 01:00 AM, Himadri Pandya wrote:
> Decrement the reference count on device_node "np" while breaking out of
> the loop. Issue identified by Coccinelle.
> 
> Signed-off-by: Himadri Pandya <himadri18.07 at gmail.com>
> ---
> Changes in V2:
> 	- Change subject line
> ---
>  arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> index 8112b39879d6..3ee1404ceef4 100644
> --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> @@ -220,6 +220,7 @@ void hlwd_pic_probe(void)
>  			irq_set_chained_handler(cascade_virq,
>  						hlwd_pic_irq_cascade);
>  			hlwd_irq_host = host;
> +			of_node_put(np);
>  			break;
>  		}
>  	}
> @@ -237,4 +238,3 @@ void hlwd_quiesce(void)
> 
>  	__hlwd_quiesce(io_base);
>  }
> -
> 

This line removal at the end of the patch is likely accidental, but really
should not be here. Otherwise,

Reviewed-by: Tyrel Datwyler <tyreld at linux.vnet.ibm.com>



More information about the Linuxppc-dev mailing list