[RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time()
Andy Lutomirski
luto at kernel.org
Tue Dec 24 12:58:24 AEDT 2019
On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
<christophe.leroy at c-s.fr> wrote:
>
> READ_ONCE() forces the read of the 64 bit value of
> vd[CS_HRES_COARSE].basetime[CLOCK_REALTIME].sec allthough
> only the lower part is needed.
Seems reasonable and very unlikely to be harmful. That being said,
this function really ought to be considered deprecated -- 32-bit
time_t is insufficient.
Do you get even better code if you move the read into the if statement?
Reviewed-by: Andy Lutomirski <luto at kernel.org>
--Andy
More information about the Linuxppc-dev
mailing list