[PATCH-tty-testing] tty/serial/8250: Add has_sysrq to plat_serial8250_port

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Dec 18 17:50:30 AEDT 2019


On Wed, Dec 18, 2019 at 04:01:11AM +0000, Dmitry Safonov wrote:
> In contrast to 8250/8250_of, legacy_serial on powerpc does fill
> (struct plat_serial8250_port). The reason is likely that it's done on
> device_initcall(), not on probe. So, 8250_core is not yet probed.
> 
> Propagate value from platform_device on 8250 probe - in case powepc
> legacy driver it's initialized on initcall, in case 8250_of it will be
> initialized later on of_platform_serial_setup().
> 
> Fixes: ea2683bf546c ("tty/serial: Migrate 8250_fsl to use has_sysrq").
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Cc: Paul Mackerras <paulus at samba.org>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: linuxppc-dev at lists.ozlabs.org
> Reported-by: kbuild test robot <lkp at intel.com>
> Signed-off-by: Dmitry Safonov <dima at arista.com>
> ---
>  It's probably better to squash this into the 8250_fsl patch.
>  I've added Fixes tag in case the branch won't be rebased.
>  Tested powerpc build manually with ppc64 cross-compiler.

I have squashed this into that original 8250_fsl patch now, and rebased
the series.  Let's see what kbuild does...

thanks,

greg k-h


More information about the Linuxppc-dev mailing list