[EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

[Xiaowei Bao]

> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon at ti.com>
> Sent: 2019年8月13日 15:30
> To: Xiaowei Bao <xiaowei.bao at nxp.com>; lorenzo.pieralisi at arm.com;
> bhelgaas at google.com; M.h. Lian <minghuan.lian at nxp.com>; Mingkai Hu
> <mingkai.hu at nxp.com>; Roy Zang <roy.zang at nxp.com>;
> l.stach at pengutronix.de; tpiepho at impinj.com; Leonard Crestez
> <leonard.crestez at nxp.com>; andrew.smirnov at gmail.com;
> yue.wang at amlogic.com; hayashi.kunihiko at socionext.com;
> dwmw at amazon.co.uk; jonnyc at amazon.com; linux-pci at vger.kernel.org;
> linux-kernel at vger.kernel.org; linuxppc-dev at lists.ozlabs.org;
> linux-arm-kernel at lists.infradead.org
> Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit
> property in EP driver.
> 
> Caution: EXT Email
> 
> On 13/08/19 11:58 AM, Xiaowei Bao wrote:
> > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is
> > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set
> > the bar_fixed_64bit with 0x14.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao at nxp.com>
> 
> Acked-by: Kishon Vijay Abraham I <kishon at ti.com>
> > ---
> > v2:
> >  - Replace value 0x14 with a macro.
> > v3:
> >  - No change.
> > v4:
> >  - send the patch again with '--to'.
> > v5:
> >  - fix the commit message.
> >
> >  drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index be61d96..ca9aa45 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -44,6 +44,7 @@ static const struct pci_epc_features
> ls_pcie_epc_features = {
> >       .linkup_notifier = false,
> >       .msi_capable = true,
> >       .msix_capable = false,
> > +     .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> >  };
> >
> >  static const struct pci_epc_features*
I check other platforms, it is 'static const struct pci_epc_features', I can get the correct 
Value use this define way in pci-epf-test.c file.
> >