[PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers

Al Viro viro at zeniv.linux.org.uk
Thu Apr 18 07:21:11 AEST 2019


On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote:
> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new compat_ptr_ioctl()
> helper makes it more correct in theory, and simplifies the code.
> 
> Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Acked-by: Felipe Balbi <felipe.balbi at linux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
>  drivers/misc/cxl/flash.c            |  8 +-------
>  drivers/misc/genwqe/card_dev.c      | 23 +----------------------
>  drivers/scsi/megaraid/megaraid_mm.c | 28 +---------------------------
>  drivers/usb/gadget/function/f_fs.c  | 12 +-----------

ACK, provided that all their ioctls are taking pointers (which is
worth mentioning in commit message, assuming it's true)


More information about the Linuxppc-dev mailing list