[PATCH v2] powerpc/vmlinux.lds: Drop binutils < 2.18 workarounds

Segher Boessenkool segher at kernel.crashing.org
Fri Apr 5 01:53:33 AEDT 2019


Hi Joel,

On Thu, Apr 04, 2019 at 12:17:40PM +0000, Joel Stanley wrote:
> On Fri, 29 Mar 2019 at 09:53, Segher Boessenkool
> <segher at kernel.crashing.org> wrote:
> > On Fri, Mar 29, 2019 at 05:14:53PM +1030, Joel Stanley wrote:
> > > -     NOTES :kernel :notes
> > > +     NOTES
> >
> > I think this still need to be
> >
> >         NOTES :kernel
> >
> > or the linker will complain.  Did you try to build ppc64_defconfig?
> 
> Yeah, I did build (and boot, in qemu) the ppc64_defconfig. I tried
> leaving in/removing the :kernel annotation in a bunch of places and as
> long as I had it in the first spot, the kernel linked.
> 
> Shall I respin with this added?

Yes please, if only so we are testing the exact same thing :-)

There may be a binutils version difference here.

> > (And I do not know if there are any tools that expect the notes in a phdr,
> > or even specifically the second phdr).

^^^ This question remains?


Segher


More information about the Linuxppc-dev mailing list