[PATCH kernel] cxl: Remove unused include

Michael Ellerman mpe at ellerman.id.au
Fri Sep 28 22:46:43 AEST 2018


Alexey Kardashevskiy <aik at ozlabs.ru> writes:
> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
> while it does not so let's remote it.

But it does use eg.

  OPAL_PHB_CAPI_MODE_SNOOP_ON
  OPAL_PHB_CAPI_MODE_CAPI

Which come from opal-api.h via opal.h.

So you should at least include opal-api.h.

cheers

> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index b66d832..8cbcbb7 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -17,7 +17,6 @@
>  #include <linux/pci.h>
>  #include <linux/of.h>
>  #include <linux/delay.h>
> -#include <asm/opal.h>
>  #include <asm/msi_bitmap.h>
>  #include <asm/pnv-pci.h>
>  #include <asm/io.h>
> -- 
> 2.11.0


More information about the Linuxppc-dev mailing list