[RFC PATCH 01/11] powerpc/tm: Reclaim transaction on kernel entry
Breno Leitao
leitao at debian.org
Fri Sep 28 06:28:57 AEST 2018
Hi Mikey,
On 09/17/2018 10:31 PM, Michael Neuling wrote:
> On Wed, 2018-09-12 at 16:40 -0300, Breno Leitao wrote:
>> This patch creates a macro that will be invoked on all entrance to the
>> kernel, so, in kernel space the transaction will be completely reclaimed
>> and not suspended anymore.
>
> There are still some calls to tm_reclaim_current() in process.c. Should these
> probably go now, right?
Yes, we shouldn't not call tm_reclaim_current() from anywhere else other than
TM_KERNEL_ENTRY anymore.
That said, I think we can still have some references for tm_reclaim_current()
in some specific checkpoints. Something as:
if (WARN_ON(MSR_TM_SUSPENDED(mfmsr())))
tm_reclaim_current(0);
I initially wrote something as BUG_ON(MSR_TM_SUSPENDED(mfmsr()) but
scripts/checkpatch.pl suggested me writing a WARN_ON() and create a recovery
pass, which seems fair.
Anyway, if you think it is not a good strategy, I can get rid of them at v2.
Thank you!
More information about the Linuxppc-dev
mailing list