[PATCH 4/4] dma-mapping: clear dev->dma_ops in arch_teardown_dma_ops
Michael Ellerman
mpe at ellerman.id.au
Wed Sep 26 14:20:19 AEST 2018
Christoph Hellwig <hch at lst.de> writes:
> Looking at the code I think this commit is simply broken for
> architectures not using arch_setup_dma_ops, but instead setting up
> the dma ops through arch specific magic.
I arch_setup_dma_ops() called from of_dma_configure(), but
pci_dma_configure() doesn't call that for this device:
static int pci_dma_configure(struct device *dev)
{
...
if (IS_ENABLED(CONFIG_OF) && bridge->parent &&
bridge->parent->of_node) {
ret = of_dma_configure(dev, bridge->parent->of_node, true);
bridge->parent is NULL.
So I don't think arch_setup_dma_ops() would help here?
> I'll revert the patch.
Thanks.
cheers
More information about the Linuxppc-dev
mailing list