[PATCH v2 2/5] powerpc/boot: Fix crt0.S syntax for clang

Joel Stanley joel at jms.id.au
Tue Sep 18 11:08:03 AEST 2018


On Tue, 18 Sep 2018 at 06:11, Nick Desaulniers <ndesaulniers at google.com> wrote:
>
> On Fri, Sep 14, 2018 at 2:08 PM Segher Boessenkool
> <segher at kernel.crashing.org> wrote:
> >
> > On Fri, Sep 14, 2018 at 10:47:08AM -0700, Nick Desaulniers wrote:
> > > On Thu, Sep 13, 2018 at 9:07 PM Joel Stanley <joel at jms.id.au> wrote:
> > > >  10:    addis   r12,r12,(-RELACOUNT)@ha
> > > > -       cmpdi   r12,RELACOUNT at l
> > > > +       cmpdi   r12,(RELACOUNT)@l
> > >
> > > Yep, as we can see above, when RELACOUNT is negated, it's wrapped in
> > > parens.
>
> Looks like this was just fixed in Clang-8:
> https://bugs.llvm.org/show_bug.cgi?id=38945
> https://reviews.llvm.org/D52188

Nice!

mpe, given we need the local references to labels fix which is also in
clang-8 I suggest we drop this patch.

Cheers,

Joel


More information about the Linuxppc-dev mailing list