[PATCH 01/12] powerpc/64s/hash: Fix stab_rr off by one initialization

Joel Stanley joel at jms.id.au
Mon Sep 17 16:51:51 AEST 2018


On Sat, 15 Sep 2018 at 01:03, Nicholas Piggin <npiggin at gmail.com> wrote:
>
> This causes SLB alloation to start 1 beyond the start of the SLB.
> There is no real problem because after it wraps it stats behaving

starts?

> properly, it's just surprisig to see when looking at SLB traces.

surprising

>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>

> ---
>  arch/powerpc/mm/slb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
> index 9f574e59d178..2f162c6e52d4 100644
> --- a/arch/powerpc/mm/slb.c
> +++ b/arch/powerpc/mm/slb.c
> @@ -355,7 +355,7 @@ void slb_initialize(void)
>  #endif
>         }
>
> -       get_paca()->stab_rr = SLB_NUM_BOLTED;
> +       get_paca()->stab_rr = SLB_NUM_BOLTED - 1;
>
>         lflags = SLB_VSID_KERNEL | linear_llp;
>         vflags = SLB_VSID_KERNEL | vmalloc_llp;
> --
> 2.18.0
>


More information about the Linuxppc-dev mailing list