[PATCH 1/2] powerpc/boot: Fix crt0.S syntax for clang

[Joel Stanley]

On Tue, 11 Sep 2018 at 21:02, Segher Boessenkool
<segher at kernel.crashing.org> wrote:
>
> On Mon, Sep 10, 2018 at 06:57:13PM +1000, Joel Stanley wrote:
> > Clang's assembler does not like the syntax of the cmpdi:
> >
> >  arch/powerpc/boot/crt0.S:168:22: error: unexpected modifier on variable reference
> >          cmpdi   12,RELACOUNT at l
> >                               ^
> >  arch/powerpc/boot/crt0.S:168:11: error: unknown operand
> >          cmpdi   12,RELACOUNT at l
> >                    ^
> > Enclosing RELACOUNT in () makes it is happy. Tested with GCC 8 and Clang
> > 8 (trunk).
>
> Is clang going to fix this?  You also might want to add a comment that
> this is a workaround for that broken assembler.

I am not sure that we need a comment, it doesn't look too out of place
compared to the other uses of wrapping symbols in ().

I did open a bug against clang though in the hope that they can fix
the behaviour:

 https://bugs.llvm.org/show_bug.cgi?id=38945

Cheers,

Joel