[PATCH v06 3/5] migration/memory: Add hotplug READD_MULTIPLE

Michael Ellerman mpe at ellerman.id.au
Tue Oct 16 11:39:29 AEDT 2018


Michael Bringmann <mwb at linux.vnet.ibm.com> writes:
> diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
> index 2b796da..9c76345 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
> @@ -541,6 +549,23 @@ static int dlpar_memory_readd_by_index(u32 drc_index)
>  	return rc;
>  }
>
> +static int dlpar_memory_readd_multiple(void)
> +{
> +	struct drmem_lmb *lmb;
> +	int rc;
> +
> +	pr_info("Attempting to update multiple LMBs\n");
> +
> +	for_each_drmem_lmb(lmb) {
> +		if (drmem_lmb_update(lmb)) {
> +			rc = dlpar_memory_readd_helper(lmb);
> +			drmem_remove_lmb_update(lmb);
> +		}
> +	}
> +
> +	return rc;
> +}

This leaves rc potentially uninitialised.

What should the result be in that case, -EINVAL ?

cheers


More information about the Linuxppc-dev mailing list