[PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

[Kees Cook]

On Fri, Oct 12, 2018 at 2:59 AM, Gustavo A. R. Silva
<gustavo at embeddedor.com> wrote:
>
>
> On 10/12/18 11:32 AM, Michael Ellerman wrote:
>>
>> Sure. The kbuild report up thread has some or most of them.
>>
>> But here's a full list:
>>
>> Failed 279/290
>> http://kisskb.ellerman.id.au/kisskb/head/1d59e2c78793d8aea9949ca71323c4583c78f488/
>>   Failed: powerpc-next/ppc64_defconfig/powerpc-gcc8           (http://kisskb.ellerman.id.au/kisskb/buildresult/13542791/log/)
>>     /kisskb/src/arch/powerpc/platforms/powermac/feature.c:1477:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/signal.h:180:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/compat.h:495:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/compat.h:496:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/compat.h:494:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>   Failed: powerpc-next/corenet64_smp_defconfig/powerpc-gcc8           (http://kisskb.ellerman.id.au/kisskb/buildresult/13542786/log/)
>>     /kisskb/src/include/linux/compat.h:494:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/compat.h:495:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>     /kisskb/src/include/linux/compat.h:496:51: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>   Failed: powerpc-next/ppc64le_defconfig/powerpc-gcc8         (http://kisskb.ellerman.id.au/kisskb/buildresult/13542777/log/)
>>     /kisskb/src/include/linux/signal.h:180:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>   Failed: powerpc-next/powernv_defconfig/powerpc-gcc8         (http://kisskb.ellerman.id.au/kisskb/buildresult/13542776/log/)
>>     /kisskb/src/include/linux/signal.h:180:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
>>
>
> Thanks, Michael.
>
>
> Kees, can you take the patches?
>
> Apparently, neither signal.h nor compat.h have a dedicated maintainer:
>
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback include/linux/signal.h
> linux-kernel at vger.kernel.org (open list)
>
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback include/linux/compat.h
> linux-kernel at vger.kernel.org (open list)

Normally things like that go through akpm, but I'm happy to carry them
if needed.

-Kees

-- 
Kees Cook
Pixel Security