[PATCH v3] powerpc/Makefile: Fix PPC_BOOK3S_64 ASFLAGS

Michael Ellerman mpe at ellerman.id.au
Thu Oct 11 21:44:29 AEDT 2018


Joel Stanley <joel at jms.id.au> writes:
> Ever since commit 15a3204d24a3 ("powerpc/64s: Set assembler machine type
> to POWER4") we force -mpower4 to be passed to the assembler irrespective
> of the CFLAGS used.
...
>
> By explicitly setting -many we can build with Clang and GCC while
> retaining the -mpower4 option.
>
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
> Following up on:
> https://lore.kernel.org/linuxppc-dev/20180914040649.1794-2-joel@jms.id.au/
> https://lore.kernel.org/linuxppc-dev/20180821010203.23213-1-anton@ozlabs.org/
>
> mpe, please trim the commit message if you think it's a bit verbose

I thought it was bit short :P

> We could test for these flags in case -many is removed in the future,
> but if an assembler does not support -many then -mpower4 will probably
> break it anyway.

Yeah that's OK, breaking hypothetical future toolchains is fine.

cheers


More information about the Linuxppc-dev mailing list