[PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

Kees Cook keescook at chromium.org
Thu Oct 11 12:35:29 AEDT 2018


On Wed, Oct 10, 2018 at 5:32 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> Kees Cook <keescook at chromium.org> writes:
>> On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
>>> Warn whenever a switch statement has a fallthrough without a comment
>>> annotating it.
>>>
>>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>>
>> Yes please. :)
>>
>> Reviewed-by: Kees Cook <keescook at chromium.org>
>
> Haha, thanks.
>
> It still pops a few errors, including in linux/signal.h & compat.h, so
> it's somewhat aspirational until we can get those fixed up :)

Gustavo, any chance you can target those two files? It could get us a
whole architecture using the flag. :)

-Kees

-- 
Kees Cook
Pixel Security


More information about the Linuxppc-dev mailing list