[PATCH] powerpc: Fix HMIs on big-endian with CONFIG_RELOCATABLE=y

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Oct 9 23:27:31 AEDT 2018


On Tue, 2018-10-09 at 21:37 +1100, Michael Ellerman wrote:
> Technically yes. But I thought because we build with mcmodel=medium
> we'll never actually get multiple TOCs in the kernel itself, so it
> doesn't actually matter.
> 
> So this seems to work for now:

Ok, fine. I forgot about DOTSYM. Will do for now.

Cheers,
Ben.

> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index 301a6a86a20f..e5566e248a02 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -1149,7 +1149,7 @@ TRAMP_REAL_BEGIN(hmi_exception_early)
>  	EXCEPTION_PROLOG_COMMON_2(PACA_EXGEN)
>  	EXCEPTION_PROLOG_COMMON_3(0xe60)
>  	addi	r3,r1,STACK_FRAME_OVERHEAD
> -	BRANCH_LINK_TO_FAR(hmi_exception_realmode) /* Function call ABI */
> +	BRANCH_LINK_TO_FAR(DOTSYM(hmi_exception_realmode)) /* Function call ABI */
>  	cmpdi	cr0,r3,0
>  
>  	/* Windup the stack. */
> 
> 
> cheers



More information about the Linuxppc-dev mailing list