[PATCH v2] powerpc/math-emu: Update macros from gmp-6.1.2

Nick Desaulniers ndesaulniers at google.com
Wed Nov 21 05:45:19 AEDT 2018


On Tue, Nov 20, 2018 at 10:20 AM Segher Boessenkool
<segher at kernel.crashing.org> wrote:
>
> On Tue, Nov 20, 2018 at 09:45:33AM +1030, Joel Stanley wrote:
> > On Tue, 20 Nov 2018 at 05:24, Nick Desaulniers <ndesaulniers at google.com> wrote:
> > > >
> > > > The only functional change I noticed was this in udiv_qrnnd.
> > AIUI the upstream source is GMP:
> >
> >  https://gmplib.org/repo/gmp/file/tip/longlong.h
> >
> > > If we're going to borrow implementations from GCC, let's borrow the
> > > same implementation. Otherwise it's hard to have confidence in this
> > > part of the patch.
> >
> > I agree we should use the upstream source.
> >
> > Segher, which tree contains the One True Upstream for longlong.h?
>
> You should probably get your updates from the same place as was used to
> get the file in the first place.

So sounds like GMP is the source to take then.  Joel, would you mind
sending a v3 with just the commit message updated to reflect the fact
that GCC and GMP differ in implementations, and this is taken from
GMP, maybe with some links?  I think that will provide more context
for future travelers.  I'd be happy to add my reviewed-by tag to that.

-- 
Thanks,
~Nick Desaulniers


More information about the Linuxppc-dev mailing list