[PATCH] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

Michael Bringmann mwb at linux.vnet.ibm.com
Thu Nov 15 01:13:39 AEDT 2018



On 11/13/2018 02:39 AM, Srikar Dronamraju wrote:
>> -static void topology_work_fn(struct work_struct *work)
>> -{
>> -	rebuild_sched_domains();
>> +	if (changed)
>> +		rebuild_sched_domains();
>>  }
>>  static DECLARE_WORK(topology_work, topology_work_fn);
>>
>> @@ -1553,7 +1424,6 @@ void __init shared_proc_topology_init(void)
>>  	if (lppaca_shared_proc(get_lppaca())) {
>>  		bitmap_fill(cpumask_bits(&cpu_associativity_changes_mask),
>>  			    nr_cpumask_bits);
>> -		numa_update_cpu_topology(false);
> 
> Shouldn't we be calling topology_schedule_update() here?

Agreed.

> 
>>  	}
>>  }
>>
> 
> 

-- 
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line  363-5196
External: (512) 286-5196
Cell:       (512) 466-0650
mwb at linux.vnet.ibm.com



More information about the Linuxppc-dev mailing list