[PATCH] powerpc/math-emu: Fix building with clang

Nick Desaulniers ndesaulniers at google.com
Tue Nov 13 06:17:04 AEDT 2018


On Mon, Nov 12, 2018 at 3:33 AM Joel Stanley <joel at jms.id.au> wrote:
> > On Thu, Nov 1, 2018 at 8:37 PM Joel Stanley <joel at jms.id.au> wrote:
> > >
> > >   arch/powerpc/math-emu/fnmsub.c:46:2: error: invalid use of a cast in a
> > >   inline asm context requiring an l-value: remove the cast or build with
> > >   -fheinous-gnu-extensions

> ./arch/powerpc/include/asm/sfp-machine.h:283:27: note: expanded from
> macro 'sub_ddmmss'
>                : "=r" ((USItype)(sh)),                                  \
>                        ~~~~~~~~~~^~~

Eek, I can of think that add_ssaaaa(), sub_ddmmss(), and umul_ppmm()
should be rewritten from the form:

asm("..." : "=r" (USItype)(arg) : ...);

to the form:

USItype temp = (USItype) arg;
asm("..." : "=r" (temp) : ...);
arg = (typeof(arg)) temp;

Rather than the flag being added.
-- 
Thanks,
~Nick Desaulniers


More information about the Linuxppc-dev mailing list