selftests/powerpc: Fix compilation issue due to asm label

Michael Ellerman patch-notifications at ellerman.id.au
Thu Nov 1 23:46:54 AEDT 2018


On Wed, 2018-10-31 at 17:18:13 UTC, "Naveen N. Rao" wrote:
> We are using 'dscr_insn' as a label in inline asm to identify if a
> SIGILL was generated by the mtspr instruction at that point. However,
> with inline assembly, the compiler is still free to duplicate the asm
> statement for optimization purposes, which results in the label being
> defined twice with the error:
> 	/tmp/ccerQCql.s:874: Error: symbol `dscr_insn' is already defined
> 
> With different compiler versions, we may also see:
> 	/tmp/ccJzLDlN.o:(.toc+0x0): undefined reference to `dscr_insn'
> 
> Remove the use of the label in the inline assembly. Instead, just look
> for the offending instruction in the signal handler.
> 
> Reported-by: Breno Leitao <leitao at debian.org>
> Signed-off-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
> Tested-by: Breno Leitao <leitao at debian.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1936f094e164cc13ebf17aba1d6b34

cheers


More information about the Linuxppc-dev mailing list