[PATCH] selftests/powerpc: Fix compilation issue due to asm label

Naveen N. Rao naveen.n.rao at linux.vnet.ibm.com
Thu Nov 1 04:24:39 AEDT 2018


Naveen N. Rao wrote:
> We are using 'dscr_insn' as a label in inline asm to identify if a
> SIGILL was generated by the mtspr instruction at that point. However,
> with inline assembly, the compiler is still free to duplicate the asm
> statement for optimization purposes, which results in the label being
> defined twice with the error:
> 	/tmp/ccerQCql.s:874: Error: symbol `dscr_insn' is already defined
> 
> With different compiler versions, we may also see:
> 	/tmp/ccJzLDlN.o:(.toc+0x0): undefined reference to `dscr_insn'
> 
> Remove the use of the label in the inline assembly. Instead, just look
> for the offending instruction in the signal handler.
> 
> Reported-by: Breno Leitao <leitao at debian.org>
> Signed-off-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
> ---

Missed adding:
Fixes: d2bf793237b3aa9c ("selftests/powerpc: Add test to verify rfi flush across a system call")

- Naveen




More information about the Linuxppc-dev mailing list