[PATCH 1/3] powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be()
Michael Ellerman
mpe at ellerman.id.au
Fri May 18 22:00:23 AEST 2018
Samuel Mendoza-Jonas <sam at mendozajonas.com> writes:
> On Mon, 2018-05-14 at 22:50 +1000, Michael Ellerman wrote:
>> Add byte-swapping versions of __raw_writeq() and __raw_rm_writeq().
>>
>> This allows us to avoid sparse warnings caused by passing __be64 to
>> __raw_writeq(), which takes unsigned long:
>>
>> arch/powerpc/platforms/powernv/pci-ioda.c:1981:38:
>> warning: incorrect type in argument 1 (different base types)
>> expected unsigned long [unsigned] v
>> got restricted __be64 [usertype] <noident>
>>
>> It's also generally preferable to use a byte-swapping accessor rather
>> than doing it by hand in the code, which is more bug prone.
>>
>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>
> For this and the following patches:
>
> Reviewed-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
Thanks.
cheers
More information about the Linuxppc-dev
mailing list