[PATCH 3/6] libnvdimm: Add device-tree based driver

Oliver oohall at gmail.com
Mon Mar 26 12:07:29 AEDT 2018

On Sat, Mar 24, 2018 at 4:07 AM, Dan Williams <dan.j.williams at intel.com> wrote:
> On Fri, Mar 23, 2018 at 1:12 AM, Oliver O'Halloran <oohall at gmail.com> wrote:
>> This patch adds peliminary device-tree bindings for the NVDIMM driver.
> *preliminary
>> Currently this only supports one bus (created at probe time) which all
>> regions are added to with individual regions being created by a platform
>> device driver.
>> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
>> ---
>> I suspect the platform driver should be holding a reference to the
>> created region. I left that out here since previously Dan has said
>> he'd rather keep the struct device internal to libnvdimm and the only
>> other way a region device can disappear is when the bus is unregistered.

> Hmm, but this still seems broken if bus teardown races region
> teardown.

Yeah looks like it.

>I think the more natural model, given the way libnvdimm is
> structured, to have each of these of_nd_region instances create their
> own nvdimm bus. Thoughts?

I'd prefer this too tbh. The main reason I'm looking at this approach
is that we plan on doing all interleave set configuration, etc from
Linux. So we'd like to have "similar" region/dimm devices end up in
the same bus to simplify validating managment ops, etc. That said, the
real enablement work for that is blocked on teams so I'm ok with
ignoring all of that for now.


More information about the Linuxppc-dev mailing list