build warning in drivers/macintosh/rack-meter.c
Aaro Koskinen
aaro.koskinen at iki.fi
Fri Mar 16 20:37:47 AEDT 2018
Hi,
On Fri, Mar 16, 2018 at 04:46:14PM +1100, Stephen Rothwell wrote:
> These warnings have beeen around for a while now;
>
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
> ^~~~~~
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
> ^~~~~~
>
> Introduced by commit
>
> 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
>
> I guess updating to a newer compiler has started generating these.
Eh, that's really embarrassing. Obviously it should be sizeof(). I can send
a fix for this and test on Xserve.
A.
More information about the Linuxppc-dev
mailing list