[PATCH] powerpc/mm: Fix section mismatch warning in stop_machine_change_mapping()

Balbir Singh bsingharora at gmail.com
Sun Mar 11 17:23:09 AEDT 2018


On Sat, Mar 10, 2018 at 7:45 AM, Mauricio Faria de Oliveira
<mauricfo at linux.vnet.ibm.com> wrote:
> Fix the warning messages for stop_machine_change_mapping(), and a number
> of other affected functions in its call chain.
>
> All modified functions are under CONFIG_MEMORY_HOTPLUG, so __meminit
> is okay (keeps them / does not discard them).
>
> Boot-tested on powernv/power9/radix-mmu and pseries/power8/hash-mmu.
>
>     $ make -j$(nproc) CONFIG_DEBUG_SECTION_MISMATCH=y vmlinux
>     ...
>       MODPOST vmlinux.o
>     WARNING: vmlinux.o(.text+0x6b130): Section mismatch in reference from the function stop_machine_change_mapping() to the function .meminit.text:create_physical_mapping()
>     The function stop_machine_change_mapping() references
>     the function __meminit create_physical_mapping().
>     This is often because stop_machine_change_mapping lacks a __meminit
>     annotation or the annotation of create_physical_mapping is wrong.
>
>     WARNING: vmlinux.o(.text+0x6b13c): Section mismatch in reference from the function stop_machine_change_mapping() to the function .meminit.text:create_physical_mapping()
>     The function stop_machine_change_mapping() references
>     the function __meminit create_physical_mapping().
>     This is often because stop_machine_change_mapping lacks a __meminit
>     annotation or the annotation of create_physical_mapping is wrong.
>     ...
>
> Signed-off-by: Mauricio Faria de Oliveira <mauricfo at linux.vnet.ibm.com>
> ---

Looks reasonable, I'd recommend trying to compile with MEMORY_HOTPLUG
and MEMORY_HOTREMOVE enabled/disabled as well

Acked-by: Balbir Singh <bsingharora at gmail.com>

Balbir Singh.


More information about the Linuxppc-dev mailing list