[PATCH] PCI/hotplug: ppc: correct a php_slot usage after free

wei.guo.simon at gmail.com wei.guo.simon at gmail.com
Wed Mar 7 19:46:04 AEDT 2018

From: Simon Guo <wei.guo.simon at gmail.com>

In pnv_php_unregister_one(), pnv_php_put_slot() might kfree
php_slot structure. But there is pci_hp_deregister() after
that with php_slot reference.

This patch moves pnv_php_put_slot() to the end of function.

Signed-off-by: Simon Guo <wei.guo.simon at gmail.com>
 drivers/pci/hotplug/pnv_php.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c
index 74f6a17..eb60692e 100644
--- a/drivers/pci/hotplug/pnv_php.c
+++ b/drivers/pci/hotplug/pnv_php.c
@@ -930,8 +930,8 @@ static void pnv_php_unregister_one(struct device_node *dn)
 	php_slot->state = PNV_PHP_STATE_OFFLINE;
-	pnv_php_put_slot(php_slot);
+	pnv_php_put_slot(php_slot);
 static void pnv_php_unregister(struct device_node *dn)

More information about the Linuxppc-dev mailing list