[PATCH] powerpc/eeh: Avoid misleading message "EEH: no capable adapters found"
Venkat Rao B
vrbagal1 at linux.vnet.ibm.com
Mon Jun 18 17:17:23 AEST 2018
On Friday 27 April 2018 06:04 AM, Russell Currey wrote:
> On Thu, 2018-03-22 at 23:10 -0300, Mauro S. M. Rodrigues wrote:
>> Due to recent refactoring in EEH in:
>> commit b9fde58db7e5 ("powerpc/powernv: Rework EEH initialization on
>> powernv")
>> a misleading message was seen in the kernel message buffer:
>>
>> [ 0.108431] EEH: PowerNV platform initialized
>> [ 0.589979] EEH: No capable adapters found
>>
>> This happened due to the removal of the initialization delay for
>> powernv
>> platform.
>>
>> Even though the EEH infrastructure for the devices is eventually
>> initialized and still works just fine the eeh device probe step is
>> postponed in order to assure the PEs are created. Later
>> pnv_eeh_post_init does the probe devices job but at that point the
>> message was already shown right after eeh_init flow.
>>
>> This patch introduces a new flag EEH_POSTPONED_PROBE to represent
>> that
>> temporary state and avoid the message mentioned above and showing the
>> follow one instead:
>>
>> [ 0.107724] EEH: PowerNV platform initialized
>> [ 4.844825] EEH: PCI Enhanced I/O Error Handling Enabled
>>
>> Signed-off-by: Mauro S. M. Rodrigues <maurosr at linux.vnet.ibm.com>
>
> Good idea, thanks for the patch.
>
> Acked-by: Russell Currey <ruscur at russell.cc>
>
Hi Mauro,
I got a chance to test your patch, I applied your patch on top of
mainline kernel commit:8efcf34a263965e471e3999904f94d1f6799d42a and
booted and I don't see the message "No capable adapters found" instead I
see "EEH: PCI Enhanced I/O Error Handling Enabled" as desired. But I
have not injected any EEH.Hope this should qualify your patch.
Tested-by:Venkat Rao B <vrbagal1 at linux.vnet.ibm.com>
Regards,
Venkat.
More information about the Linuxppc-dev
mailing list