SB600 for the Nemo board has non-zero devices on non-root bus
Michael Ellerman
patch-notifications at ellerman.id.au
Tue Jun 5 00:10:28 AEST 2018
On Wed, 2017-12-06 at 11:03:52 UTC, Christian Zigotzky wrote:
> On 06 December 2017 at 09:37AM, Christian Zigotzky wrote:
> > On 03 December 2017 at 10:43AM, Christian Zigotzky wrote:
> > >
> > > On 3. Dec 2017, at 00:02, Olof Johansson <olof at lixom.net> wrote:
> > >>
> > >> Typo, should be ';', not ':'. I obviously didn't even try
> compiling this. :)
> > >>
> > >>
> > >> -Olof
> > >
> > > Hi Olof,
> > >
> > > Thanks a lot for your patch! I will test it on Wednesday.
> > >
> > > Cheers,
> > > Christian
> >
> >
> > Hi Olof,
> >
> > I tested your patch today. Unfortunately the kernel 4.15-rc2 doesn't
> compile with your patch.
> >
> > Error messages:
> >
> > ^~~~~~~~~
> > arch/powerpc/platforms/pasemi/pci.c: In function ‘pas_pci_init’:
> > arch/powerpc/platforms/pasemi/pci.c:298:2: error: implicit
> declaration of function ‘pci_set_flag’
> [-Werror=implicit-function-declaration]
> > pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS);
> > ^~~~~~~~~~~~
> > cc1: some warnings being treated as errors
> >
> > ---
> >
> > I figured out that we need 'pci_set_flags' instead of 'pci_set_flag'.
> I modified your patch and after that the kernel compiles. Please find
> attached the new patch.
> >
> > Cheers,
> > Christian
>
> Hi Olof,
>
> Many thanks for your patch! :-) The RC2 of kernel 4.15 boots without any
> problems on my P.A. Semi Nemo board (A-EON AmigaOne X1000). I don’t need
> the additional boot argument 'pci=pcie_scan_all' anymore.
>
> Is it possible to merge it via the powerpc tree?
>
> Thanks,
> Christian
>
> arch/powerpc/platforms/pasemi/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
> index 5ff6108..ea54ed2 100644
> --- a/arch/powerpc/platforms/pasemi/pci.c
> +++ b/arch/powerpc/platforms/pasemi/pci.c
> @@ -224,6 +224,8 @@ void __init pas_pci_init(void)
> return;
> }
>
> + pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS);
> +
> for (np = NULL; (np = of_get_next_child(root, np)) != NULL;)
> if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np))
> of_node_get(np);
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/eff06ef0891d200eb0ddd156c6e96c
cheers
More information about the Linuxppc-dev
mailing list