[PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers
Stewart Smith
stewart at linux.ibm.com
Fri Jun 1 13:52:28 AEST 2018
Haren Myneni <haren at linux.vnet.ibm.com> writes:
> NX increments readOffset by FIFO size in receive FIFO control register
> when CRB is read. But the index in RxFIFO has to match with the
> corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX
> may be processing incorrect CRBs and can cause CRB timeout.
>
> VAS FIFO offset is 0 when the receive window is opened during
> initialization. When the module is reloaded or in kexec boot, readOffset
> in FIFO control register may not match with VAS entry. This patch adds
> nx_coproc_init OPAL call to reset readOffset and queued entries in FIFO
> control register for both high and normal FIFOs.
>
> Signed-off-by: Haren Myneni <haren at us.ibm.com>
I've yet to go and check out the skiboot patch properly, but should this
be both:
Fixes: b0d6c9bab crypto/nx: Add P9 NX support for 842 compression engine
CC: stable # v4.14+
as otherwise "rmmod ; insmod" will crash, and possibly even issues over kexec?
--
Stewart Smith
OPAL Architect, IBM.
More information about the Linuxppc-dev
mailing list