[PATCH] powerpc/mobility: Fix node detach/rename problem
kbuild test robot
lkp at intel.com
Mon Jul 30 02:31:20 AEST 2018
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc6 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-mobility-Fix-node-detach-rename-problem/20180729-213517
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
arch/powerpc/platforms/pseries/dlpar.c: In function 'dlpar_detach_node':
>> arch/powerpc/platforms/pseries/dlpar.c:276:9: error: passing argument 1 of 'memset' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
memset(dn->name, 0, strlen(dn->name));
^~
In file included from include/linux/string.h:20:0,
from arch/powerpc/include/asm/paca.h:19,
from arch/powerpc/include/asm/current.h:16,
from include/linux/mutex.h:14,
from include/linux/notifier.h:14,
from arch/powerpc/platforms/pseries/dlpar.c:16:
arch/powerpc/include/asm/string.h:23:15: note: expected 'void *' but argument is of type 'const char *'
extern void * memset(void *,int,__kernel_size_t);
^~~~~~
cc1: all warnings being treated as errors
vim +276 arch/powerpc/platforms/pseries/dlpar.c
259
260 int dlpar_detach_node(struct device_node *dn)
261 {
262 struct device_node *child;
263 int rc;
264
265 child = of_get_next_child(dn, NULL);
266 while (child) {
267 dlpar_detach_node(child);
268 child = of_get_next_child(dn, child);
269 }
270
271 rc = of_detach_node(dn);
272 if (rc)
273 return rc;
274
275 dn->phandle = 0;
> 276 memset(dn->name, 0, strlen(dn->name));
277
278 return 0;
279 }
280
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 23683 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20180730/6dddd807/attachment-0001.gz>
More information about the Linuxppc-dev
mailing list