powerpc/xmon: Fix disassembly since printf changes
Michael Ellerman
patch-notifications at ellerman.id.au
Thu Jul 19 16:06:09 AEST 2018
On Tue, 2018-07-17 at 00:50:38 UTC, Michael Ellerman wrote:
> The recent change to add printf annotations to xmon inadvertently made
> the disassembly output ugly, eg:
>
> c00000002001e058 7ee00026 mfcr r23
> c00000002001e05c fffffffffae101a0 std r23,416(r1)
> c00000002001e060 fffffffff8230000 std r1,0(r3)
>
> The problem being that negative 32-bit values are being displayed in
> full 64-bits.
>
> The printf conversion was actually correct, we are passing unsigned
> long so it should use "lx". But powerpc instructions are only 4 bytes
> and the code only reads 4 bytes, so inst should really just be
> unsigned int, and that also fixes the printing to look the way we
> want:
>
> c00000002001e058 7ee00026 mfcr r23
> c00000002001e05c fae101a0 std r23,416(r1)
> c00000002001e060 f8230000 std r1,0(r3)
>
> Fixes: e70d8f55268b ("powerpc/xmon: Add __printf annotation to xmon_printf()")
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/941d810725ad48cc21948f4cff8cf7
cheers
More information about the Linuxppc-dev
mailing list