[PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset
Pingfan Liu
kernelfans at gmail.com
Tue Jul 3 16:50:38 AEST 2018
commit 52cdbdd49853 ("driver core: correct device's shutdown order")
places an assumption of supplier<-consumer order on the process of probe.
But it turns out to break down the parent <- child order in some scene.
E.g in pci, a bridge is enabled by pci core, and behind it, the devices
have been probed. Then comes the bridge's module, which enables extra
feature(such as hotplug) on this bridge.
This will break the parent<-children order and cause failure when
"kexec -e" in some scenario.
v2 -> v3:
It is a little hard to impose both "parent<-child" and "supplier<-consumer"
on devices_kset. Hence v3 drops this method, postpones the issue to shutdown
time instead of probing, and utilizes device-tree info during shutdown
instead of the item's seq inside devices_kset.
Pingfan Liu (4):
drivers/base: fold the routine of device's shutdown into a func
drivers/base: utilize device tree info to shutdown devices
drivers/base: clean up the usage of devices_kset_move_last()
Revert "driver core: correct device's shutdown order"
drivers/base/base.h | 1 -
drivers/base/core.c | 196 +++++++++++++++++++++++--------------------------
drivers/base/dd.c | 8 --
include/linux/device.h | 1 +
4 files changed, 92 insertions(+), 114 deletions(-)
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
Cc: Grygorii Strashko <grygorii.strashko at ti.com>
Cc: Christoph Hellwig <hch at infradead.org>
Cc: Bjorn Helgaas <helgaas at kernel.org>
Cc: Dave Young <dyoung at redhat.com>
Cc: linux-pci at vger.kernel.org
Cc: linuxppc-dev at lists.ozlabs.org
--
2.7.4
More information about the Linuxppc-dev
mailing list