[PATCH v4 01/11] macintosh/via-pmu: Fix section mismatch warning

Finn Thain fthain at telegraphics.com.au
Mon Jul 2 18:21:18 AEST 2018

The pmu_init() function has the __init qualifier, but the ops struct
that holds a pointer to it does not. This causes a build warning.
The driver works fine because the pointer is only dereferenced early.

The function is so small that there's negligible benefit from using
the __init qualifier. Remove it to fix the warning, consistent with
the other ADB drivers.

Tested-by: Stan Johnson <userm57 at yahoo.com>
Signed-off-by: Finn Thain <fthain at telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert at linux-m68k.org>
 drivers/macintosh/via-pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 25c1ce811053..f8a2c917201f 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -378,7 +378,7 @@ static int pmu_probe(void)
 	return vias == NULL? -ENODEV: 0;
-static int __init pmu_init(void)
+static int pmu_init(void)
 	if (vias == NULL)
 		return -ENODEV;

More information about the Linuxppc-dev mailing list