[PATCH] drivers/macintosh: Use true for boolean value

Michael Ellerman mpe at ellerman.id.au
Wed Jan 24 11:47:02 AEDT 2018


"Gustavo A. R. Silva" <gustavo at embeddedor.com> writes:

> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com>
> ---
>  drivers/macintosh/windfarm_pm72.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This seems to be common across all those drivers. Can you please send
one patch to fix them all to use bool:

  $ git grep "started = " drivers/macintosh/
  drivers/macintosh/therm_adt746x.c:              int started = 0;
  drivers/macintosh/therm_adt746x.c:                      started = 1;
  drivers/macintosh/windfarm_pm112.c:             slots_started = 1;
  drivers/macintosh/windfarm_pm112.c:             started = 1;
  drivers/macintosh/windfarm_pm121.c:             pm121_started = 1;
  drivers/macintosh/windfarm_pm72.c:              started = 1;
  drivers/macintosh/windfarm_pm81.c:              wf_smu_started = 1;
  drivers/macintosh/windfarm_pm91.c:              wf_smu_started = 1;
  drivers/macintosh/windfarm_rm31.c:              started = 1;

cheers


More information about the Linuxppc-dev mailing list