powerpc: Use octal numbers for file permissions

Michael Ellerman patch-notifications at ellerman.id.au
Mon Jan 22 14:34:05 AEDT 2018


On Thu, 2017-01-12 at 03:54:13 UTC, Russell Currey wrote:
> Symbolic macros are unintuitive and hard to read, whereas octal constants
> are much easier to interpret.  Replace macros for the basic permission
> flags (user/group/other read/write/execute) with numeric constants
> instead, across the whole powerpc tree.
> 
> Introducing a significant number of changes across the tree for no runtime
> benefit isn't exactly desirable, but so long as these macros are still
> used in the tree people will keep sending patches that add them.  Not only
> are they hard to parse at a glance, there are multiple ways of coming to
> the same value (as you can see with 0444 and 0644 in this patch) which
> hurts readability.
> 
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> Reviewed-by: Cyril Bur <cyrilbur at gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/57ad583f2086d55ada284c54bfc440

cheers


More information about the Linuxppc-dev mailing list